feat(ds): Implement recalibration for sampling mode PROJECT #80241
+277
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80241 +/- ##
==========================================
+ Coverage 78.07% 78.11% +0.03%
==========================================
Files 7188 7184 -4
Lines 317611 317360 -251
Branches 43759 43733 -26
==========================================
- Hits 247981 247897 -84
+ Misses 63293 63116 -177
- Partials 6337 6347 +10 |
* master: (67 commits) feat(dynamic-sampling): Sampling breakdown (#80304) feat(profiling): add organizations:continuous-profiling to the list of exposable features (#80236) chore(broadcasts): remove cta column from broadcast model (#80201) feat(dynamic-sampling): Use sample rates endpoint (#80235) feat(issues): Rearrange all events columns, sizes (#80296) fix(issues): All event table pagination counts (#80297) fix(issues): Preserve query parameters on all events close (#80295) feat(issues): Hide "comment" button until focused (#80283) fix(sentry-app): Adds better validation for invalid token request bodies (#80289) feat(workflow_engine): Add in hook for producing occurrences from the stateful detector (#80168) feat(issue summary) New structured issue summary design (#80273) feat(workflow_engine): Return status change messages when a stateful detector resolves (#80122) feat(insights): Add insights query date range footer hook (#80276) ref(crons): Switch to cronsim in sample data generator (#80278) feat(issue-details): Hide merged/similar issues for non-error issues (#80284) feat(issue summary) Update issue summary model (#80270) feat(crons): Add cronsim behind an option (#80271) fix(anomaly detection): add alerts analytics reqs to utils/analytics.tsx (#80281) feat(trace-explorer): Sort traces by timestamp in EAP (#80274) feat(workflow_engine): Implement basic evaluation in `DataCondition` (#80118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for project mode in recalibration. In the top-level batch task, organizations are split in two groups:
recalibrate_orgs_batchtask, which internally now checks the configured target sample rate for the organization.recalibrate_projects_batch, which internally loads span volumes by project and stores a new recalibration cache entry for each of the projects.Rule generation for this bias checks the sampling mode and loads and loads the project's recalibration factor in project mode.
Closes https://github.com/getsentry/projects/issues/193